Deduplicated float tests and unified in floats/mod.rs #148206

xonx4l · 2025-10-28T12:23:42Z

In this PR Float tests are deduplicated and are unified in floats/mod.rs, as discussed in #141726.

The moved float tests are:

-> test_powf
-> test_exp
-> test_exp2
-> test_ln
-> test_log_generic
-> test_log2
-> test_log10
-> test_asinh
-> test_acosh
-> test_atanh
-> test_gamma
-> test_ln_gamma

Closes: #141726

r? tgross35

rustbot · 2025-10-28T12:23:47Z

tgross35 is currently at their maximum review capacity.
They may take a while to respond.

library/std/tests/floats/lib.rs

xonx4l · 2025-11-11T12:19:21Z

Any update @bjorn3 ?

bjorn3 · 2025-11-11T12:22:56Z

CI is still failing.

xonx4l · 2025-11-11T12:27:03Z

CI is still failing.

ok let me fix .

rustbot · 2025-11-14T08:23:07Z

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

LorrensP-2158466 · 2025-11-17T23:39:14Z

library/coretests/tests/floats/mod.rs

+        let inf: Float = Float::INFINITY;
+        let neg_inf: Float = Float::NEG_INFINITY;
+        assert_biteq!((10.0 as Float).log(10.0), 1.0);
+        assert_approx_eq!((2.3 as Float).log(3.5), 0.664858, Float::LOG_APPROX);


This test here for f128 will fail because the precision is much higher, if you look at the original test, the expected value is much more precise than what you have written:

assert_approx_eq!(2.3f128.log(3.5), 0.66485771361478710036766645911922010272, TOL);

When testing higher precision floats, you need much more precise expected values or the tests will fail, as they do now. In Miri, this is even more strict.

If you look at the source of f16 constants, they use much more digits after the decimal point than needed:

pub const PI: f16 = 3.14159265358979323846264338327950288_f16;

So you should probably do that as well.

Okay it makes sense . Thanks

tgross35 · 2025-11-19T14:09:50Z

Thank you for the final cleanup here. Until CI is fixed,
@rustbot author

rustbot · 2025-11-19T14:09:55Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

xonx4l · 2025-11-19T18:27:09Z

Thank you for the final cleanup here. Until CI is fixed, @rustbot author

Will finish this as soon as possible . A bit busy these days.

rustbot · 2026-01-16T18:11:58Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

xonx4l · 2026-01-19T03:56:42Z

@tgross35 is anything more needed on this ?

tgross35 · 2026-01-22T08:58:16Z

Thank you for all the work here! Final results LGTM.

@bors r+

rust-bors · 2026-01-22T08:58:20Z

📌 Commit 6ac8ff7 has been approved by tgross35

It is now in the queue for this repository.

tgross35 · 2026-01-22T08:59:45Z

library/coretests/tests/floats/mod.rs

-        f16: #[cfg(any(miri, target_has_reliable_f16))],
-        f128: #[cfg(any(miri, target_has_reliable_f128))],
+        f16: #[cfg(any(miri, target_has_reliable_f16_math))],
+        f128: #[cfg(any(miri, target_has_reliable_f128_math))],
    },
    test<Float> {
-        let pi: Float = Float::PI;
+        let pi: Float = consts::PI;
        let nan: Float = Float::NAN;
        let inf: Float = Float::INFINITY;
        let neg_inf: Float = Float::NEG_INFINITY;
-        assert_biteq!((0.0 as Float).to_degrees(), 0.0);
-        assert_approx_eq!((-5.8 as Float).to_degrees(), -332.31552117587745090765431723855668471);
+        assert_biteq!(flt(0.0).to_degrees(), 0.0);
+        assert_approx_eq!(flt(-5.8).to_degrees(), -332.31552117587745090765431723855668471);
        assert_approx_eq!(pi.to_degrees(), 180.0, Float::PI_TO_DEGREES_APPROX);
        assert!(nan.to_degrees().is_nan());
        assert_biteq!(inf.to_degrees(), inf);
        assert_biteq!(neg_inf.to_degrees(), neg_inf);
-        assert_biteq!((1.0 as Float).to_degrees(), 57.2957795130823208767981548141051703);
+        assert_biteq!(flt(1.0).to_degrees(), 57.2957795130823208767981548141051703);
    }
 }

 float_test! {
    name: to_radians,
    attrs: {
-        f16: #[cfg(any(miri, target_has_reliable_f16))],
-        f128: #[cfg(any(miri, target_has_reliable_f128))],
+        f16: #[cfg(any(miri, target_has_reliable_f16_math))],
+        f128: #[cfg(any(miri, target_has_reliable_f128_math))],


The target_has_reliable_* -> target_has_reliable_*_math changes were not required here; to_radians/to_degrees are just math operations and don't need to link libm.

It's not worth blocking this on, but would you be able to send a followup changing them back? Or do the change in this PR if you get to it before it merges.

@tgross35 I just saw this and bors already committed this PR . So I think a followup will be the best option here .

…tgross35 Deduplicated float tests and unified in floats/mod.rs In this PR Float tests are deduplicated and are unified in floats/mod.rs, as discussed in rust-lang#141726. The moved float tests are: -> test_powf -> test_exp -> test_exp2 -> test_ln -> test_log_generic -> test_log2 -> test_log10 -> test_asinh -> test_acosh -> test_atanh -> test_gamma -> test_ln_gamma Closes: rust-lang#141726

@ghost

…uwer Rollup of 8 pull requests Successful merges: - #148206 (Deduplicated float tests and unified in floats/mod.rs) - #151042 (fix fallback impl for select_unpredictable intrinsic) - #151220 (option: Use Option::map in Option::cloned) - #151260 (Handle unevaluated ConstKind in in_operand) - #151441 (Fix ICE: Don't try to evaluate type_consts when eagerly collecting items) - #151465 (codegen: clarify some variable names around function calls) - #151469 (llvm: Tolerate dead_on_return attribute changes) - #151476 (Avoid `-> ()` in derived functions.) r? @ghost

rust-bors · 2026-01-22T12:23:02Z

⌛ Testing commit 6ac8ff7 with merge e822724...

Workflow: https://github.com/rust-lang/rust/actions/runs/21248296883

Deduplicated float tests and unified in floats/mod.rs In this PR Float tests are deduplicated and are unified in floats/mod.rs, as discussed in #141726. The moved float tests are: -> test_powf -> test_exp -> test_exp2 -> test_ln -> test_log_generic -> test_log2 -> test_log10 -> test_asinh -> test_acosh -> test_atanh -> test_gamma -> test_ln_gamma Closes: #141726

JonathanBrouwer · 2026-01-22T12:27:45Z

@bors yield
Yield to enclosing rollup that failed spuriously

rust-bors · 2026-01-22T12:27:49Z

Auto build cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/21248296883

The next pull request likely to be tested is #151485.

@ghost

…uwer Rollup of 8 pull requests Successful merges: - #148206 (Deduplicated float tests and unified in floats/mod.rs) - #151042 (fix fallback impl for select_unpredictable intrinsic) - #151220 (option: Use Option::map in Option::cloned) - #151260 (Handle unevaluated ConstKind in in_operand) - #151441 (Fix ICE: Don't try to evaluate type_consts when eagerly collecting items) - #151465 (codegen: clarify some variable names around function calls) - #151469 (llvm: Tolerate dead_on_return attribute changes) - #151476 (Avoid `-> ()` in derived functions.) r? @ghost

JonathanBrouwer · 2026-01-22T12:35:16Z

Actually I think this PR failed that rollup
@bors r-
#151485 (comment)

Not sure, if you disagree start a try job and then r+ again

rust-bors · 2026-01-22T12:35:21Z

Commit 6ac8ff7 has been unapproved.

@ghost

…uwer Rollup of 8 pull requests Successful merges: - #148206 (Deduplicated float tests and unified in floats/mod.rs) - #151042 (fix fallback impl for select_unpredictable intrinsic) - #151220 (option: Use Option::map in Option::cloned) - #151260 (Handle unevaluated ConstKind in in_operand) - #151441 (Fix ICE: Don't try to evaluate type_consts when eagerly collecting items) - #151465 (codegen: clarify some variable names around function calls) - #151469 (llvm: Tolerate dead_on_return attribute changes) - #151476 (Avoid `-> ()` in derived functions.) r? @ghost

rustbot assigned tgross35 Oct 28, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 28, 2025